Re: BUG #4137: Postgres drives pg_standby %r param to delete WAL file before processing

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Wojciech Strzalka <wstrzalka(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4137: Postgres drives pg_standby %r param to delete WAL file before processing
Date: 2008-05-03 11:29:16
Message-ID: 1209814156.4264.256.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, 2008-05-02 at 22:01 +0100, Simon Riggs wrote:
> On Fri, 2008-05-02 at 18:11 +0000, Wojciech Strzalka wrote:

> > Keep archive history : 0000000100000001000000DB and later
> ...................................................^^
> > running restore : OK
>
> Looks like the first message gives and incorrect archive cut-off point.

I confess that I don't fully understand your description of the sequence
of activities you performed. But I do see that a file has been removed
that is *after* the one requested, which should never happen. So this is
a valid bug.

Not managed to recreate this yet, but I'm posting my suggested fix now.
This is a general fix, so will fix any problem with those symptoms.

Please test this and report back. You can do this in two ways:
1. recompile pg_standby only and retry. I enclose a fully patched copy
of pg_standby.c to assist you, in case that helps
2. apply complete patch to postgres source tree and retry

I will attempt to recreate the problem and test this patch also using
method (2)

[Not yet ready to be applied to core, until we get test results.]

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

Attachment Content-Type Size
pg_standby.c text/x-csrc 17.2 KB
standby_restartbug.v1.patch text/x-patch 3.4 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Mathias Seiler 2008-05-03 21:27:16 BUG #4141: Aliases in rules vanished, but they work
Previous Message Simon Riggs 2008-05-02 21:01:42 Re: BUG #4137: Postgres drives pg_standby %r param to delete WAL file before processing