Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Minor changes to Recovery related code

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Cc: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [HACKERS] Minor changes to Recovery related code
Date: 2008-04-01 16:17:34
Message-ID: 1207066654.4238.38.camel@ebony.site (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Thu, 2008-03-27 at 17:34 +0000, Simon Riggs wrote:
> Follow-up during March 2008 CommitFest
> 
> On Thu, 2007-06-07 at 21:53 +0100, Simon Riggs wrote:
> > On Sat, 2007-03-31 at 00:51 +0200, Florian G. Pflug wrote:

> > - pg_stop_backup() will wait until the WAL file that ends the backup is
> > safely archived, even if a failure to archive occurs. This is a change
> > to current behaviour, but since it implements the originally *expected*
> > behaviour IMHO it should be the default.
> 
> The most straightforward thing is to make pg_stop_backup() wait as
> described above.
> 
> If people want it to timeout, they can use a statement_timeout as
> suggested by Florian.
> 
> This can be implemented by having the function poll in an infinite loop
> for archive_status/LOG.done. Also, as Florian suggests, we should have
> it output a WARNING message every 60 seconds.
> 
> I'll write a patch now.

Patch to implement waiting pg_stop_backup(). 

Tested and ready to apply, includes docs.

-- 
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com 

  PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

Attachment: stop_backup_wait.v1.patch
Description: text/x-patch (7.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: David FetterDate: 2008-04-01 16:35:03
Subject: Re: Cast as compound type
Previous:From: Peter EisentrautDate: 2008-04-01 16:00:10
Subject: Several tags around PostgreSQL 7.1 broken

pgsql-patches by date

Next:From: Simon RiggsDate: 2008-04-01 16:42:21
Subject: Re: Improve shutdown during online backup
Previous:From: Bernd HelmleDate: 2008-04-01 16:09:01
Subject: Re: psql command aliases support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group