Skip site navigation (1) Skip section navigation (2)

Re: Re : Win32 binaries test / pg_dump problem

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: Re : Win32 binaries test / pg_dump problem
Date: 2004-05-28 11:04:05
Message-ID: 1207.24.211.141.25.1085742245.squirrel@www.dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Cyril VELTER said:
> From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
>
>> Cyril VELTER wrote:
>>
>> >     if you psql -f test.sql basetest from the windows shell to a
>> >     windows
> or
>> > linux database, you'll get a missing data error :
>> >
>> > psql:test.sql:9: ERROR:  missing data for column "b"
>> > CONTEXT:  COPY test, line 1: "a"
>> >
>> >     if you psql -f test.sql basetest from a linux shell to a windows
>> >     or
>> > linux database, you won't get an error
>>
>> Sounds like we should have psql open the file in binary mode on
>> Windows. Would that cause problems? I doubt it, but I wonder.
>>
>
>    you might be right, I just found some information on msdn that fseek
>    for
> example is influenced by ctrl-z when the file is opened in text mode.
>
>    I'm not sure that this is the cause of the second problem (backend
>    crash
> on copy to) though.
>
>    do you known where this modification needs to be done ?
>
>    cyril
>

probably in src/bin/psql/command.c::process_file()

instead of mode "r" we should probably use the predefined constant
PG_BINARY_R

cheers

andrew





In response to

Responses

pgsql-patches by date

Next:From: Rory Campbell-LangeDate: 2004-05-28 11:22:47
Subject: pg_dump and schema namespace notes
Previous:From: Harald FuchsDate: 2004-05-28 10:55:59
Subject: Re: pg_dump --comment?

pgsql-hackers-win32 by date

Next:From: Andreas PflugDate: 2004-05-28 12:00:18
Subject: Compiling libpq with VisualC
Previous:From: Cyril VELTERDate: 2004-05-28 10:18:57
Subject: Re: Re : Win32 binaries test / pg_dump problem

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group