I believe that there is a small bug in src/port/rint.c when the input
parameter has a fractional part of 0.5 which is demonstrated by the
attached program. It appears that the PG version of rint() rounds in the
wrong direction with respect to glibc.
The fix is, of course, to add an equals into the if() comparisons on
lines 21 and 26, so that when the fractional part is 0.5, it rounds in
the opposite direction instead.
I'm sure that this will have practically zero effect on the code,
however it may be worth applying for correctness and consistency with
other platform implementations.
ILande - Open Source Consultancy
Description: text/x-csrc (507 bytes)
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2008-01-20 21:31:19|
|Subject: Re: Friendly help for psql |
|Previous:||From: Greg Smith||Date: 2008-01-20 20:55:54|
|Subject: Re: [HACKERS] bgwriter_lru_multiplier blurbs inconsistent|