Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Re-enable the old code in xlog.c that tried to use

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <greg(dot)stark(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Re-enable the old code in xlog.c that tried to use
Date: 2009-01-11 19:22:00
Message-ID: 1194.1231701720@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Gregory Stark <greg(dot)stark(at)enterprisedb(dot)com> writes:
> tgl(at)postgresql(dot)org (Tom Lane) writes:
> ! #if defined(USE_POSIX_FADVISE) && defined(POSIX_FADV_DONTNEED)

> I think if we're not putting the AC_CHECK_RUN check in then this should just
> be HAVE_POSIX_FADVISE not USE_POSIX_FADVISE. The latter was the define I made
> if the run check passed.

No, checking the DECL part as well is critical (if we don't see a
declaration we risk ABI incompatibility).  And in any case I'm insisting
on being able to turn this off in pg_config_manual.h.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-01-11 19:32:10
Subject: Re: Recovery Test Framework
Previous:From: Tom LaneDate: 2009-01-11 19:14:50
Subject: Re: posix_fadvise v22

pgsql-committers by date

Next:From: Tom LaneDate: 2009-01-12 05:10:45
Subject: pgsql: Implement prefetching via posix_fadvise() for bitmap index scans.
Previous:From: Gregory StarkDate: 2009-01-11 19:06:38
Subject: Re: pgsql: Re-enable the old code in xlog.c that tried to use

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group