From: | Neil Conway <neilc(at)samurai(dot)com> |
---|---|
To: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Avoid needless copy in nodeMaterial |
Date: | 2007-10-16 04:05:23 |
Message-ID: | 1192507523.6133.21.camel@goldbach |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Attached is a patch that avoids a needless copy of the result tuple in
nodeMaterial, in the case that we don't have a previously-materialized
tuple to return. We can just return the TTS produced by executing our
child node, rather than returning a copy of it.
I didn't bother pulling the MinimalTuple out of "outerslot" and stuffing
it back into the nodeMaterial's result slot, as AFAICS that is not
necessary. Although I suppose you could make a cleanliness argument that
that would be worth doing instead.
(This is 8.4 material...)
-Neil
Attachment | Content-Type | Size |
---|---|---|
material_copy_tweak-1.patch | text/x-patch | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-10-16 04:34:12 | Re: Avoid needless copy in nodeMaterial |
Previous Message | ITAGAKI Takahiro | 2007-10-16 04:04:28 | V3 protocol is slower than V2 |