Skip site navigation (1) Skip section navigation (2)

Re: BUG #3674: Unnecessary checkpoints by WAL Writer

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #3674: Unnecessary checkpoints by WAL Writer
Date: 2007-10-15 20:24:06
Message-ID: 1192479846.5272.15.camel@ebony.site (view raw or flat)
Thread:
Lists: pgsql-bugs
On Fri, 2007-10-12 at 13:06 -0400, Tom Lane wrote:
> "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)gmail(dot)com> writes:
> > WAL Writer requests unnecessary checkpoints with CHECKPOINT_CAUSE_XLOG.
> > RedoRecPtr, declared in xlog.c, is initialized at StartupXLOG() but never
> > updated in WAL Writer because it never calls XLogInsert(). It judges excess
> > of segments wrongly.
> 
> Good catch.  I think the best fix for this is to make XLogWrite call
> GetRedoRecPtr and recheck the condition before actually sending a
> signal.

Yes, very good catch, my bad. Thanks Itagaki.

-- 
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com


In response to

pgsql-bugs by date

Next:From: Dave PageDate: 2007-10-15 21:54:12
Subject: Re: BUG #3667: Job scheduling with Greenplum fails
Previous:From: Simon RiggsDate: 2007-10-15 20:19:04
Subject: Re: BUG #3667: Job scheduling with Greenplum fails

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group