Skip site navigation (1) Skip section navigation (2)

Re: set_ps_display during recovery

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: set_ps_display during recovery
Date: 2007-09-30 14:34:58
Message-ID: 1191162898.4174.118.camel@ebony.site (view raw or flat)
Thread:
Lists: pgsql-patches
On Sun, 2007-09-30 at 10:28 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Sat, 2007-09-29 at 14:34 -0400, Tom Lane wrote:
> >> Hmm, not right there, because we don't know that the file actually
> >> exists yet.  Applied with modifications ...
> 
> > Double hmmm, that means when we are waiting for file X in pg_standby the
> > ps display will still show "recovering X-1". I'd prefer to set ps before
> > the call to RestoreArchivedFile(), since that is where the wait occurs.
> > I got that wrong myself.
> 
> Well, if you think that's an important time component --- which it could
> be in archive situations, I guess --- there should be a separate PS
> display state for it.  

Agreed. I think it will save time answering questions on -admin later.

> Perhaps "fetching XXX" vs "restoring XXX"?

Restoring is the right term, I think.

-- 
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com


In response to

pgsql-patches by date

Next:From: Simon RiggsDate: 2007-09-30 14:52:38
Subject: Re: set_ps_display during recovery
Previous:From: Tom LaneDate: 2007-09-30 14:28:27
Subject: Re: set_ps_display during recovery

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group