Skip site navigation (1) Skip section navigation (2)

Re: stats_block_level

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Peter Eisentraut" <peter_e(at)gmx(dot)net>,<pgsql-hackers(at)postgresql(dot)org>,"Dave Page" <dpage(at)postgresql(dot)org>
Subject: Re: stats_block_level
Date: 2007-07-31 17:15:08
Message-ID: 1185902108.4170.14.camel@ebony.site (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, 2007-07-31 at 13:06 -0400, Alvaro Herrera wrote:
> Simon Riggs wrote:
> > On Tue, 2007-07-31 at 12:33 -0400, Alvaro Herrera wrote:
> > > Tom Lane wrote:
> > > > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > > > > I agree.  Let's remove stats_start_collector and merge the other two
> > > > > into a single setting.  Anything more than that is overkill.
> > > > 
> > > > So what are we going to call the one surviving GUC variable?
> > > 
> > > "collect_stats"
> > 
> > In the patch recently submitted, I opted for stats_collection.
> 
> I think we tend to give emphasis to the verb rather than the noun, e.g.
> redirect_stderr, log_connections.
> 
> 
> FWIW I just noticed we have a variable named "krb_caseins_users" which I
> think is not such a great name for it.  Prolly best to change it now
> while it's still in the oven.
> 
> > Methinks it should be: stats_<something>, so that people find it in the
> > same place as stats_query_string, which is still there.
> 
> Hum, but the order in postgresql.conf is arbitrary, right?

Yes, though the order in 'show all' is alphabetical.

However, I agree with your comment on verb first, so lets do
"collect_stats".

-- 
  Simon Riggs
  EnterpriseDB  http://www.enterprisedb.com


In response to

pgsql-hackers by date

Next:From: Josh BerkusDate: 2007-07-31 17:16:57
Subject: Re: Machine available for community use
Previous:From: Gavin M. RoyDate: 2007-07-31 17:08:35
Subject: Re: Machine available for community use

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group