| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
| Cc: | Greg Smith <gsmith(at)gregsmith(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Logging checkpoints and other slowdown causes |
| Date: | 2007-05-28 20:48:39 |
| Message-ID: | 1180385320.26297.17.camel@silverbirch.site |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Mon, 2007-05-28 at 21:25 +0100, Heikki Linnakangas wrote:
> - RequestCheckpoint and CreateCheckpoint was changed to take a
> CheckpointReason enum as argument, instead of boolean flags. This allows
> printing a different message depending on the cause of checkpoint, and
> is also cleaner IMHO.
Looks good.
I'd be inclined to make the reason code for creating/dropping database
the same and just say "Cluster DDL" or something, since for analysis
purposes we just want to know it was DDL.
I'd rather see the timings in seconds rather than ms. Counting
significant digits will be a pain...
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-05-28 20:56:15 | Re: [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee |
| Previous Message | Heikki Linnakangas | 2007-05-28 20:25:31 | Re: Logging checkpoints and other slowdown causes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-28 20:48:41 | Re: Seq scans status update |
| Previous Message | Heikki Linnakangas | 2007-05-28 20:25:31 | Re: Logging checkpoints and other slowdown causes |