Skip site navigation (1) Skip section navigation (2)

Re: Improving deadlock error messages

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improving deadlock error messages
Date: 2007-04-23 22:05:59
Message-ID: 1177365959.16415.170.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, 2007-04-23 at 17:38 -0400, Tom Lane wrote:
> I'm really still opposed to the entire concept.  You're proposing to put
> a lot of fragile-looking code into a seldom-exercised error path.

There's certainly not a "lot" of code: the patch just adds a few
syscache lookups, wrapped in a PG_LOCK_NOWAIT() block.

As for fragility, I think the important point is whether it's safe to
siglongjmp() out of LockAcquire(); the rest is just window dressing.

-Neil



In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2007-04-23 22:11:29
Subject: Re: Better error message for select_common_type()
Previous:From: Andrew DunstanDate: 2007-04-23 22:05:19
Subject: Re: RETURN QUERY in PL/PgSQL?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group