Re: RESET command seems pretty disjointed now

From: Neil Conway <neilc(at)samurai(dot)com>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florian Pflug <fgp(dot)phlo(dot)org(at)gmail(dot)com>, Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: RESET command seems pretty disjointed now
Date: 2007-04-23 20:04:07
Message-ID: 1177358647.16415.140.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2007-04-17 at 16:34 +0300, Marko Kreen wrote:
> Attached patch does following conversions:

ISTM it would be cleaner to use an enum to identify the different
variants of the DISCARD command, rather than a character string.

Is guc.c still the logical place for the implementation of DISCARD?
Something under backend/commands might be better, although I don't see a
real obvious place for it.

The psql tab completion code requires updating for the new DISCARD
command.

-Neil

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message korryd 2007-04-23 20:05:24 Re: EXPLAIN/EXPLAIN ANALYSE for pl/pgsql functions
Previous Message Tom Lane 2007-04-23 19:47:20 Re: BUG #3245: PANIC: failed to re-find shared loc k o b j ect