Skip site navigation (1) Skip section navigation (2)

Re: Fast CLUSTER

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fast CLUSTER
Date: 2007-02-22 22:49:10
Message-ID: 1172184550.3874.196.camel@silverbirch.site (view raw or flat)
Thread:
Lists: pgsql-patches
On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote:

> Cool.  I noticed that the SGML seems broken here:

Corrected. 

> You need to close the <listitem> and <para> opened in the COPY mention.
> 
> > + 
> > + static void
> > + heap_sync_relation(Relation rel)
> > + {
> > + 	if (!rel->rd_istemp)
> 
> No comment in this function?

I've added more comments as you suggest.

Thanks for the review.

-- 
  Simon Riggs             
  EnterpriseDB   http://www.enterprisedb.com


Attachment: fast_cluster.v2.patch
Description: text/x-patch (10.3 KB)

In response to

Responses

pgsql-patches by date

Next:From: Jim C. NasbyDate: 2007-02-23 06:28:20
Subject: Re: [HACKERS] HOT WIP Patch - version 2
Previous:From: Guillaume SmetDate: 2007-02-22 22:17:45
Subject: Re: First implementation of GIN for pg_trgm

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group