Re: scrollable cursor sup. for SPI

From: Neil Conway <neilc(at)samurai(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)hotmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, jonah(dot)harris(at)gmail(dot)com
Subject: Re: scrollable cursor sup. for SPI
Date: 2007-01-15 17:26:58
Message-ID: 1168882018.6174.86.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sun, 2007-01-14 at 13:57 +0100, Pavel Stehule wrote:
> this patch adds scrollable support functions to SPI. It's necessary for
> scrollable cursors in plpgsql. Original API is without changes.

One trivial point is that if you're going to use an int * to represent
an "optional int" argument, it would be better to at least use a "const"
qualifier. However, in this case, it might be simpler to just represent
"no options passed" as 0.

Barring any objections, I'll apply a slightly improved version of this
patch tomorrow.

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-01-15 18:05:28 Re: O_DIRECT support for Windows
Previous Message Neil Conway 2007-01-15 17:19:40 Re: pg_dumpall default database