Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Date: 2012-04-18 13:53:50
Message-ID: 1165.1334757230@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> My vote is to revert this altogether and leave it be. In the
> alternative, make it an error.

You mean in HEAD too? I don't agree with that, for sure. What this
patch is accomplishing is to make sure that the less-commonly-used
programs have similar command-line-parsing behavior to psql and pg_dump,
where we long ago realized that failure to check this carefully could
result in very confusing behavior. (Especially on machines where
getopt is willing to rearrange the command line.)

I agree with Andrew that this is a bug fix. I can see the argument
for not applying it to back branches, but not for declaring that it's
not a bug.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-04-18 13:56:43 pgsql: psql: Add tab completion for CREATE/ALTER ROLE name WITH
Previous Message Peter Eisentraut 2012-04-18 09:46:45 Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2012-04-18 13:56:49 Re: psql: tab completions for 'WITH'
Previous Message Robert Haas 2012-04-18 12:28:14 Re: Bug tracker tool we need