Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] Out of memory error causes Abort, Abort tries

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [BUGS] Out of memory error causes Abort, Abort tries
Date: 2006-11-28 02:22:41
Message-ID: 1164680561.7773.86.camel@dogma.v10.wvs (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On Wed, 2006-11-22 at 21:41 -0500, Tom Lane wrote:
> I wrote:
> > Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> >> Wasteful how? Do you mean that it would clutter the code, or that it
> >> would cause unnecessary overhead? 
> 
> > Well, it'd be an extra however-many-KB of memory for each backend that
> > would mostly go unused.  The rest of a backend's working memory pretty
> > much pulls its weight, but a TransactionAbortContext wouldn't.  OTOH,
> > maybe these days a few dozen KB isn't worth worrying about.
> 
> After further thought I concluded that overloading ErrorContext for this
> purpose is way too risky, so I've committed changes that create a
> separate context for AbortTransaction to use:
> http://archives.postgresql.org/pgsql-committers/2006-11/msg00199.php
> 
> I think the patch would apply cleanly to 8.1 but have not got time to
> check it now.  Less sure about older branches.  Are we excited about
> trying to back-patch this?  I think it'd really need rather more testing
> before I'd want to stick it into the stable branches ...
> 

Everything in the patch makes sense to me, and it certainly solved my
test case.

I'm just fine with the fix only in 8.2. I can work around it until I can
upgrade.

Thanks!
	Jeff Davis




In response to

pgsql-hackers by date

Next:From: Michael FuhrDate: 2006-11-28 04:31:29
Subject: ecpg_config.h not installed
Previous:From: Joseph SDate: 2006-11-28 02:08:21
Subject: Re: doc patch for savepoints

pgsql-bugs by date

Next:From: Tom LaneDate: 2006-11-28 02:56:50
Subject: Re: BUG #2781: database dump/restore problems
Previous:From: Jeff DavisDate: 2006-11-28 00:46:12
Subject: Re: Unexpected sort order.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group