Skip site navigation (1) Skip section navigation (2)

Re: pgsql: pg_stop_backup wascallingXLogArchiveNotify() twice for the

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Tom Lane" <tgl(at)postgresql(dot)org>,<pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: pg_stop_backup wascallingXLogArchiveNotify() twice for the
Date: 2006-11-15 08:27:33
Message-ID: 1163579254.27956.127.camel@silverbirch.site (view raw or flat)
Thread:
Lists: pgsql-committers
On Tue, 2006-11-14 at 17:40 -0500, Bruce Momjian wrote:
> Simon Riggs wrote:
> > On Thu, 2006-06-22 at 17:43 -0300, Tom Lane wrote:
> > > Log Message:
> > > -----------
> > > pg_stop_backup was calling XLogArchiveNotify() twice for the newly created
> > > backup history file.  Bug introduced by the 8.1 change to make pg_stop_backup
> > > delete older history files.  Per report from Masao Fujii.
> > > 
> > > Tags:
> > > ----
> > > REL8_1_STABLE
> > > 
> > > Modified Files:
> > > --------------
> > >     pgsql/src/backend/access/transam:
> > >         xlog.c (r1.222.2.3 -> r1.222.2.4)
> > >         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c.diff?r1=1.222.2.3&r2=1.222.2.4)
> > 
> > 
> > This doesn't seem to be mentioned in the 8.1.5 release notes, so people
> > would not be aware they should upgrade to fix this.
> 
> We don't mention every fix for every minor release.  People should
> upgrade anyway, as we state in the FAQ.  Is there a reason this item was
> significant?

archiving doesn't work without this fix, but there's no message to
indicate why not.

If we don't mention it in the release notes then it becomes an
unexplained bug, which then makes people lose confidence, since when
they report it nobody can explain the bug (as just happened on -admin).

-- 
  Simon Riggs             
  EnterpriseDB   http://www.enterprisedb.com



In response to

pgsql-committers by date

Next:From: Peter EisentrautDate: 2006-11-16 14:28:41
Subject: pgsql: String fix
Previous:From: Bruce MomjianDate: 2006-11-15 01:09:09
Subject: pgsql: Improve broadcast wording for failover/clustering documentation.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group