Re: Proposal: vacuum and autovacuum parameters tocontrol freezing

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Gregory Stark" <stark(at)enterprisedb(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgreSQL(dot)org>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Subject: Re: Proposal: vacuum and autovacuum parameters tocontrol freezing
Date: 2006-11-05 21:39:25
Message-ID: 1162762766.3587.932.camel@silverbirch.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sun, 2006-11-05 at 14:47 -0500, Gregory Stark wrote:
> "Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
>
> > vacuum_freeze_min The latest TransactionId that will be "frozen" during
> > a VACUUM is calculated by CurrentTransactionId - vacuum_freeze_min.
> >
> > vacuum_freeze_max
> > The maximum age, calculated as distance from CurrentTransactionId, that
> > will be allowed before a autovacuum will be forced for that database
> > object.
>
> I think it's clearer if "min" and "max" are considered adjectives and always
> have a subject they modify. Otherwise it's unclear what they refer to.
>
> So "vacuum_freeze_min_age" and "vacuum_freeze_max_age" instead.
>
> That way it's unambiguous which is which. Ie, that it's minimum and maximum
> age and not minimum and maximum transaction id which would be the other way
> around.

Sounds logical. Hadn't seen that you could take it both ways.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-11-05 21:44:43 Re: Proposal: vacuum and autovacuum parameters tocontrol freezing
Previous Message Andrew Dunstan 2006-11-05 21:14:17 WIP 2 interpreters for plperl

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-11-05 21:44:43 Re: Proposal: vacuum and autovacuum parameters tocontrol freezing
Previous Message Andrew Dunstan 2006-11-05 21:14:17 WIP 2 interpreters for plperl