Skip site navigation (1) Skip section navigation (2)

Re: updated patch for selecting large results sets in

From: Chris Mair <chrisnospam(at)1006(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: updated patch for selecting large results sets in
Date: 2006-08-28 23:31:04
Message-ID: 1156807864.4026.161.camel@dell.home.lan (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> > > I am confused.  I assume \g and ; should be affected, like Peter says. 
> > > Tom, what *every* command are you talking about?  You mean \d?
> > 
> > Like I said, I thought we were intending to modify \g's behavior only;
> > that was certainly the implication of the discussion of "\gc".

At some point you OKed the "\g and ;" proposal.
I admit I was quick adding the "and ;" part, but it seemed so natural
once we agreed on using a variable.


> OK, got it.  I just don't see the value to doing \g and not ;. I think
> the \gc case was a hack when he didn't have \set.  Now that we have
> \set, we should be consistent.

I agree with this statement.

If we have a variable that switches just between two versions of \g,
we could have gone with using \u (or whatever) in the first place.

In the mean time I have been converted by the variable camp, and
I think the variable should change "\g" and ";" together, consistently.

If we find we can't live with the performance overhead of that
if(FETCH_COUNT), it is still not clear why we would be better
off moving it into the \g code path only.

Is it because presumably \g is used less often in existing psql scripts?

Bye, Chris.



-- 

Chris Mair
http://www.1006.org



In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-08-28 23:51:28
Subject: Re: updated patch for selecting large results sets
Previous:From: Tom LaneDate: 2006-08-28 23:20:57
Subject: Re: updated patch for selecting large results sets

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-08-28 23:51:28
Subject: Re: updated patch for selecting large results sets
Previous:From: Tom LaneDate: 2006-08-28 23:20:57
Subject: Re: updated patch for selecting large results sets

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group