Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch to fix plpython on OS X

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <mike(at)fuhr(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Patch to fix plpython on OS X
Date: 2005-07-24 13:40:42
Message-ID: 1150.24.211.165.134.1122212442.squirrel@www.dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Michael Fuhr said:

> I just built Python 2.3 and it does indeed format the error differently
> than later versions (the format appears to have changed in 2.3.1):
>
[snip]
> I've attached two new files that should go in the plpython directory:
>
> resultmap
> expected/plpython_error_py23.out
>
> A problem with this patch is that it assumes a version of Python
> based on the OS, which might clean up the current buildfarm but
> that isn't really correct.  Is there a better way to handle this?


This is completely unnecessary - pg_regress has an alternative result
mechanism that doesn't rely on a resultmap file. Just name your alternative
result file foo_n.out instead of foo.out, for some n in [0-9]. In this case,
call it, say, plpython_error_1.out. Job done, and no OS dependence.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Ron MayerDate: 2005-07-24 13:44:24
Subject: Re: A Guide to Constraint Exclusion (Partitioning)
Previous:From: Michael FuhrDate: 2005-07-24 13:21:11
Subject: Re: [HACKERS] Patch to fix plpython on OS X

pgsql-patches by date

Next:From: Tom LaneDate: 2005-07-24 14:46:47
Subject: Re: Regression - GNUmakefile - pg_usleep
Previous:From: Michael FuhrDate: 2005-07-24 13:21:11
Subject: Re: [HACKERS] Patch to fix plpython on OS X

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group