Skip site navigation (1) Skip section navigation (2)

Re: ScanDirections

From: Neil Conway <neilc(at)samurai(dot)com>
To: James William Pye <pgsql(at)jwp(dot)name>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: ScanDirections
Date: 2006-02-20 03:32:24
Message-ID: 1140406344.2615.54.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
On Sun, 2006-02-19 at 19:46 -0700, James William Pye wrote:
> In any case, some parts of the patch merely makes some code make use of the
> sdir.h macros instead of depending on -1/0/1--heapam in particular. At least
> those portions should be applied, no?

I agree: using the symbolic names for the ScanDirection alternatives is
more readable than using magic numbers, and costs us nothing.

-Neil



In response to

pgsql-patches by date

Next:From: Luke LonerganDate: 2006-02-20 03:47:43
Subject: Re: WIP: further sorting speedup
Previous:From: Tom LaneDate: 2006-02-20 02:51:43
Subject: Re: ScanDirections

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group