Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Adding a --quiet option to initdb

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Devrim GUNDUZ <devrim(at)commandprompt(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Adding a --quiet option to initdb
Date: 2006-01-25 14:28:04
Message-ID: 1138199284.3268.11.camel@swithin (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Wed, 2006-01-25 at 16:08 +0200, Devrim GUNDUZ wrote:
> Hi,
> 
> Attached is a patch which adds --quiet and --q option to initdb. I
> personally needed this option while writing a document and taking
> screenshot :) It only shows the error and warning messages, as well as
> the last lines.
> 
> I've updated the docs. Regression tests pass.
> 
> This is my first patch to PostgreSQL source, so please guide me if I
> have done something wrong.
> 

Devrim,

What's wrong with just sending stdout to /dev/null? If that eats error
messages too then we should probably fix initdb to send those to stderr.

But if we are going to do this, then I also noticed a couple of things:

. you should explicitly initialize the quiet variable, in keeping with
the style of the others nearby.

. the idiom

   if (! quiet) 
   {
      fputs(_("some message"),stdout);
      fflush(stdout);
   }

should not be endlessly repeated. Make it a macro or a function.

I wonder if we can just set rid of all those fflush() calls by
unbuffering stdout with a single call to setbuf() or setvbuf()?



cheers

andrew




In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2006-01-25 14:29:10
Subject: Re: Suggestions for post-mortem...
Previous:From: Devrim GUNDUZDate: 2006-01-25 14:08:44
Subject: Adding a --quiet option to initdb

pgsql-patches by date

Next:From: Devrim GUNDUZDate: 2006-01-25 15:22:22
Subject: Re: [PATCHES] Adding a --quiet option to initdb
Previous:From: Devrim GUNDUZDate: 2006-01-25 14:08:44
Subject: Adding a --quiet option to initdb

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group