Skip site navigation (1) Skip section navigation (2)

Re: Uninstall scripts for contrib

From: Neil Conway <neilc(at)samurai(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Uninstall scripts for contrib
Date: 2006-01-16 05:13:11
Message-ID: 1137388391.9145.69.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote:
> *** contrib/chkpass/Makefile    27 Sep 2005 17:13:00 -0000      1.7
> --- contrib/chkpass/Makefile    14 Jan 2006 23:16:03 -0000
> ***************
> *** 1,9 ****
> ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.6 2004/08/20
> 20:13:02 momjian Exp $
>   
>   MODULE_big = chkpass
>   OBJS = chkpass.o
>   SHLIB_LINK = $(filter -lcrypt, $(LIBS))
>   DATA_built = chkpass.sql
>   DOCS = README.chkpass
>   
>   ifdef USE_PGXS
> --- 1,10 ----
> ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.7 2005/09/27
> 17:13:00 tgl Exp $
>   
>   MODULE_big = chkpass
>   OBJS = chkpass.o
>   SHLIB_LINK = $(filter -lcrypt, $(LIBS))
>   DATA_built = chkpass.sql
> + DATA = uninstall.sql
>   DOCS = README.chkpass
>   
>   ifdef USE_PGXS 

The change to $PostgreSQL$ is bogus (perhaps due to the way you setup
cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also,
the patch doesn't actually add any files called "uninstall.sql".

-Neil



In response to

Responses

pgsql-patches by date

Next:From: David FetterDate: 2006-01-16 05:55:39
Subject: Re: Uninstall scripts for contrib
Previous:From: Neil ConwayDate: 2006-01-16 04:33:21
Subject: Re: inferred param types for PREPARE

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group