Skip site navigation (1) Skip section navigation (2)

Re: plpython crash on exception

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, Postgres Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: plpython crash on exception
Date: 2007-11-22 18:33:16
Message-ID: 11332.1195756396@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane escribi:
>> This patch isn't acceptable because va_copy() isn't portable.
>> 
>> I'm kinda wondering why PLy_printf and the functions after it even
>> exist.  They look like rather poorly done reimplementations of
>> functionality that exists elsewhere in the backend (eg, stringinfo.c).
>> In particular, why malloc and not palloc?

> See attached patch.

> I didn't bother to change the PLy_malloc and friends because I think
> that would be too much change for 8.3.  PLy_realloc is gone though
> because there are no callers left after this patch.

Yeah, that is about what I was thinking too.  Are you set up to
back-patch this as far as 7.3?  If so, please apply.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2007-11-22 19:29:57
Subject: Re: plpython crash on exception
Previous:From: Alvaro HerreraDate: 2007-11-22 18:29:21
Subject: Re: plpython crash on exception

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group