Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)

--On Saturday, August 30, 2003 00:17:41 -0400 Bruce Momjian
<pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:

> Larry Rosenman wrote:
>>
>>
>> --On Saturday, August 30, 2003 01:09:54 -0300 "Marc G. Fournier"
>> <scrappy(at)hub(dot)org> wrote:
>>
>>
>> >
>> > 'K, but why the change to NEEDS_REENTRANT_FUNC_NAMES in the first
>> > place?
>> >
>> > The thing that has me most confused here is that the end result is the
>> > same with or without the patch, from what I can tell ... the right
>> > side of the && will always resolve to TRUE, before or after the patch
>> > ... no?
>> I want to conditionalize ONLY getpwuid_r, and not strerror_r and
>> gethostbyname_r.
>>
>> So, I changed the NEED_REENTRANT_FUNC_NAMES to no, or undefined in the
>> template, and need a configure check to set HAVE_GETPWUID_R, so we will
>> use getpwuid_r in the ENABLE_THREADS case.
>>
>> UnixWare does NOT have strerror_r nor does it have gethostbyname_r, and
>> the libc versions are reentrant in libc, for those 2. We need to use
>> getpwuid_r for
>> threaded apps.
>>
>> Does this clarify things?
>
> Yes, and that is the complex part because _some_ non-*_r functions are
> thread-safe, and some are not. I have to determine if we have other
> such platforms before I figure out how to fix it in the cleanest way.
>
> In most platforms that are like this, I think, they have all the *_r
> functions even if all of them are not required.
well, this is not true on FreeBSD.

it does NOT have gethostbyname_r (on 5.1-CURRENT as of last nite).

It does have getpwuid_r and strerror_r.

FWIW.

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749