Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Remove outdated comments from the regression test files.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove outdated comments from the regression test files.
Date: 2010-11-27 20:46:21
Message-ID: 1125.1290890781@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Nov 27, 2010, at 2:49 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> Who's going to be the first to say that being git-centric can't ever be
>> a bad thing?  ;-)

> At least for me, referring to it that way makes finding the original patch an order of magnitude faster (git show hash).  YMMV.

[ shrug... ]  You need to take the long view here.  We're not working on
the assumption that git is the last SCM this project will ever use.
Even granting that it is, I don't think git hashes are adequately stable;
loading the code into a different repository would likely result in new
hashes.  And AFAIK there is no mechanism that would fix hash references
embedded in commit log messages (or the code).

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andreas 'ads' ScherbaumDate: 2010-11-27 20:48:05
Subject: Small documentation enhancement for default_tablespace
Previous:From: Robert HaasDate: 2010-11-27 20:29:20
Subject: Re: pgsql: Remove outdated comments from the regression test files.

pgsql-committers by date

Next:From: Tom LaneDate: 2010-11-27 21:09:54
Subject: pgsql: Point out in default_tablespace's description that CREATEDATABA
Previous:From: Robert HaasDate: 2010-11-27 20:29:20
Subject: Re: pgsql: Remove outdated comments from the regression test files.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group