Skip site navigation (1) Skip section navigation (2)

Re: (was COPY FROM) performance improvements

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>,Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,Luke Lonergan <LLonergan(at)greenplum(dot)com>,Alon Goldshuv <agoldshuv(at)greenplum(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: (was COPY FROM) performance improvements
Date: 2005-08-10 21:22:41
Message-ID: 1123708961.4010.73.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
On Wed, 2005-08-10 at 11:37 -0400, Tom Lane wrote:
> "Luke Lonergan" <LLonergan(at)greenplum(dot)com> writes:
> > Yes, I think one thing we've learned is that there are important parts
> > of the code, those that are in the data path (COPY, sort, spill to
> > disk, etc) that are in dire need of optimization.  For instance, the
> > fgetc() pattern should be banned everywhere in the data path.
> 
> this discussion
> seems to presume that raw speed on Intel platforms is the only thing
> that matters.  We have a few other concerns.  Portability, readability,
> maintainability, and correctness all trump platform-specific
> optimizations.

I am interested in the general principle here, not this specific case.

As you know, I have raised the need for specific hardware tuning in
certain critical areas on a number of occasions. I very much respect the
need for all of the other aspects of code quality mentioned.

Pipeline parallelism is a feature of all modern CPUs since the Pentium,
not just Intel's. I think judicious exploitation of hardware features
that are common to multiple hardware architectures would be of
considerable benefit to everybody. We do already exploit some common
hardware tuning recommendations, such as buffer word alignment, but not
others such as false sharing avoidance and pipeline parallelism of key
loops. (There may be others...)

I say "judicious" because I do not presume that I am the judge ... but I
hope that judgements in these areas can fall towards the side of greater
performance as often as possible. Hardware and OS do exist, much as I
would prefer the simplicity of life in a layered IT architecture.

Best Regards, Simon Riggs


In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-08-10 21:29:37
Subject: Re: (was COPY FROM) performance improvements
Previous:From: Alvaro HerreraDate: 2005-08-10 17:33:32
Subject: Re: [HACKERS] Autovacuum loose ends

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group