Re: WAL replay failure after file truncation(?)

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Manfred Koizar <mkoi-pg(at)aon(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WAL replay failure after file truncation(?)
Date: 2005-05-27 15:54:46
Message-ID: 1117209286.3844.559.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2005-05-25 at 21:24 +0200, Manfred Koizar wrote:
> WAL replay does not apply changes to nonexistent blocks,
> but it keeps a list (hash table, file, whatever) of those blocks.
> When a truncate WAL record is found, all entries for blocks affected
> by the truncation are removed from the list. Is it sufficient to
> remember just the relation and the block number or do we need the
> contents a well?
>
> If the list is non-empty at the end of WAL replay, this is evidence of
> a serious problem (file system corruption or Postgres bug).

Seems like a very neat solution.

It has no side effects and seems fairly performant.

Judging by the number of PANICs reported, the data structure would be
mostly empty anyhow.

Best Regards, Simon Riggs

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Parker 2005-05-27 15:56:35 Re: logging sql from JDBC
Previous Message Simon Riggs 2005-05-27 15:45:24 Re: logging sql from JDBC