Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:

--- a/src/port/exec.c
+++ b/src/port/exec.c
@@ -357,6 +357,7 @@ pipe_read_line(char *cmd, char *line, int maxsize)
 
    if (fgets(line, maxsize, pgver) == NULL)
    {
+       pclose(pgver);      /* no error checking */
        perror("fgets failure");
        return NULL;
    }

Doesn't this risk having pclose trash the errno setting that perror is
going to print?  If you must do this, please do it in the other order.

			regards, tom lane

In response to

• pgsql: Fix inconsequential FILE pointer leakage at 2010-12-16 19:47:25 from Alvaro Herrera

Responses

• Re: pgsql: Fix inconsequential FILE pointer leakage at 2010-12-16 20:16:58 from Alvaro Herrera

pgsql-committers by date

Next:	From: Alvaro Herrera	Date: 2010-12-16 20:16:30
	Subject: pgsql: Avoid clobbering errno, per comment from Tom.
Previous:	From: Alvaro Herrera	Date: 2010-12-16 19:47:25
	Subject: pgsql: Fix inconsequential FILE pointer leakage