Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Since this patch overwrites the previous SO_PEERCRED patch I assume you
> want it to work on Linux, too. On Linux SCM_CREDS is called
Overwrite? It looks like an addition to me. I think the #ifdef tests
in ident_unix are in the wrong order, however: we should prefer
SO_PEERCRED if available, since that works with old clients. As written
the postmaster code will select SCM_CREDS if both methods are available,
which is the wrong choice IMHO.
> The invocation
> changes to StrNCpy look suspicious; see the comment at StrNCpy in c.h. In
> one place you include errno.h twice.
These are good points.
regards, tom lane
In response to
pgsql-patches by date
|Next:||From: Serguei Mokhov||Date: 2001-08-18 16:33:19|
|Subject: Re: WIN32 errno patch|
|Previous:||From: Peter Eisentraut||Date: 2001-08-18 14:52:00|
|Subject: Re: Patch: use SCM_CREDS authentication over PF_LOCAL