Skip site navigation (1) Skip section navigation (2)

Re: making use of large TLB pages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: making use of large TLB pages
Date: 2002-09-29 15:36:23
Message-ID: 11074.1033313783@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Neil Conway <neilc(at)samurai(dot)com> writes:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> OK, personally, I would like to see an actual speedup of PostgreSQL
>> queries before I would apply such a OS-specific, version-specific
>> patch.

> Don't be silly. A performance improvement is a performance
> improvement.

No, Bruce was saying that he wanted to see demonstrable improvement
*due to this specific change* before committing to support a
platform-specific API.  I agree with him, actually.  If you do the
TLB code and can't measure any meaningful performance improvement
when using it vs. when not, I'd not be excited about cluttering the
distribution with it.

> I think it's at least worth implementing -- if it doesn't provide a
> noticeable performance improvement, then we don't need to merge it.

You're on the same page, you just don't realize it...

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Masaru SugawaraDate: 2002-09-29 15:58:02
Subject: Re: Does setof record in plpgsql work well in 7.3?
Previous:From: Tom LaneDate: 2002-09-29 15:30:23
Subject: Re: Do we want a CVS branch now?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group