On Wed, 2005-02-02 at 00:39 -0500, Tom Lane wrote:
> isViewOnTempTable_walker. If that isn't euphonious to you, then change
> the name of isViewOnTempTable. Everywhere else that we have walker
> subroutines, foo() invokes foo_walker(). You need a seriously good reason
> to deviate from that convention.
[...]
> If we do have to do it this way, a minor readability improvement would
> be to write the CREATE case first and CREATE OR REPLACE second.
Patch applied to HEAD, including the above suggested changes.
Thanks for the patch, Koju.
-Neil
In response to
pgsql-hackers by date
| Next: | From: Oleg Bartunov | Date: 2005-02-02 07:27:02 |
| Subject: Re: Huge memory consumption during vacuum (v.8.0) |
| Previous: | From: Neil Conway | Date: 2005-02-02 05:52:31 |
| Subject: Re: patch for temporary view from TODO list |
pgsql-patches by date
| Next: | From: Peter Eisentraut | Date: 2005-02-02 11:22:50 |
| Subject: libpq API incompatibility between 7.4 and 8.0 |
| Previous: | From: Neil Conway | Date: 2005-02-02 05:52:31 |
| Subject: Re: patch for temporary view from TODO list |