| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | yamt(at)mwd(dot)biglobe(dot)ne(dot)jp (YAMAMOTO Takashi) |
| Cc: | pgsql-novice(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] systable_getnext_ordered |
| Date: | 2011-02-01 00:02:26 |
| Message-ID: | 11059.1296518546@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-novice |
yamt(at)mwd(dot)biglobe(dot)ne(dot)jp (YAMAMOTO Takashi) writes:
> the attached patch is to avoid unnecessary detoast'ing and EOF marker pages
> when possible. does it make sense?
The blob page size is already chosen not to allow for out-of-line
storage, not to mention that pg_largeobject doesn't have a TOAST table.
So I think avoiding detoasting is largely a waste of time. I'm
unexcited about the other consideration too --- it looks to me like it
just makes truncation slower, more complicated, and hence more
bug-prone, in return for a possible speedup that probably nobody will
ever notice.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-02-01 00:09:05 | Re: Error code for "terminating connection due to conflict with recovery" |
| Previous Message | Kevin Grittner | 2011-01-31 23:55:04 | Re: SSI patch version 14 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | matty jones | 2011-02-01 00:54:27 | Primary keys in a single column table and text vs varchar |
| Previous Message | YAMAMOTO Takashi | 2011-01-31 23:39:24 | Re: [NOVICE] systable_getnext_ordered |