Skip site navigation (1) Skip section navigation (2)

Re: error in compilation!

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: error in compilation!
Date: 2006-05-27 21:46:26
Message-ID: 11042.1148766386@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
I wrote:
> Currently looking through the rest of the patch.  I'm wondering
> about appendStringLiteral: maybe we should kill that entirely
> in favor of using PQescapeStringConn?  It's not nearly bright
> enough about encoding for instance (and it *will* be used in
> client-only encodings).

We could make an appendStringLiteralConn, which would do this correctly
for most of the utility programs.  However there's a problem for
pg_restore: it doesn't necessarily have a PGconn at all.  (Consider
the case of pg_restore producing text output.)

It seems that the alternatives are to export PQescapeStringInternal
from libpq, or to duplicate its functionality in appendStringLiteral.
Don't much like either, but perhaps the second is less bad.  Any
opinions?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Martijn van OosterhoutDate: 2006-05-27 21:59:39
Subject: Re: Inefficient bytea escaping?
Previous:From: Marc G. FournierDate: 2006-05-27 21:31:31
Subject: Re: anoncvs still slow

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group