Re: Tired of -Wold-style-definition already

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tired of -Wold-style-definition already
Date: 2004-11-17 23:43:17
Message-ID: 1100734997.26213.1.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2004-11-17 at 14:59 -0500, Tom Lane wrote:
> > Would it not be possible to suppress the warnings just for the
> > flex-generated code?
>
> IMHO it's not worth the trouble.

I think this is the better course. At least here, flex-generated files
produce warnings even without -Wold-style-definition:

% gcc -O2 -Wall -Wmissing-prototypes -fno-strict-aliasing -g -I.
-I../../../src/include -D_GNU_SOURCE -c -o gram.o gram.c
-MMD
In file included from gram.y:8445:
scan.c:6065: warning: no previous prototype for 'base_yyget_lineno'
scan.c:6074: warning: no previous prototype for 'base_yyget_in'
scan.c:6082: warning: no previous prototype for 'base_yyget_out'
scan.c:6090: warning: no previous prototype for 'base_yyget_leng'
scan.c:6099: warning: no previous prototype for 'base_yyget_text'
scan.c:6108: warning: no previous prototype for 'base_yyset_lineno'
scan.c:6120: warning: no previous prototype for 'base_yyset_in'
scan.c:6125: warning: no previous prototype for 'base_yyset_out'
scan.c:6130: warning: no previous prototype for 'base_yyget_debug'
scan.c:6135: warning: no previous prototype for 'base_yyset_debug'
scan.c:6141: warning: no previous prototype for 'base_yylex_destroy'
% flex --version
flex 2.5.31
% gcc --version
gcc-3.4 (GCC) 3.4.2 (Debian 3.4.2-3)
[...]

-Neil

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-11-18 01:22:26 Re: Tired of -Wold-style-definition already
Previous Message Peter Eisentraut 2004-11-17 23:13:34 Re: pg_resetxlog options