Skip site navigation (1) Skip section navigation (2)

Re: printTable API (was: Show INHERIT in \du)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Subject: Re: printTable API (was: Show INHERIT in \du)
Date: 2008-03-30 16:16:46
Message-ID: 10998.1206893806@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> So, it looks like:

>  1. describe malloc's the cells to zero, but print just does a local
> calloc without any initialisation.

There isn't any functional difference there.  I am not sure, but I think
the reason print.c has its own malloc wrappers instead of depending on
common.c's is that we use print.c in some bin/scripts/ programs that
do not want common.c too.

>  2. describe only does an mbvalidate for WIN32, but print does it in all cases.

I don't know why describe only does that for WIN32; it looks
inconsistent to me too.  Possibly some trolling in the CVS history would
give a clue about this.


If you're not actively working on this patch right now, I am going to go
ahead and commit the other open patches for describe.c.  If you do have
a patch in progress, I'm willing to hold off to avoid any merge
conflicts.  Let me know.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Brendan JurdDate: 2008-03-30 16:27:16
Subject: Re: printTable API (was: Show INHERIT in \du)
Previous:From: Heikki LinnakangasDate: 2008-03-30 16:06:59
Subject: Re: printTable API (was: Show INHERIT in \du)

pgsql-patches by date

Next:From: Brendan JurdDate: 2008-03-30 16:27:16
Subject: Re: printTable API (was: Show INHERIT in \du)
Previous:From: Heikki LinnakangasDate: 2008-03-30 16:06:59
Subject: Re: printTable API (was: Show INHERIT in \du)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group