Skip site navigation (1) Skip section navigation (2)

Re: additional GCC warning flags

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: additional GCC warning flags
Date: 2004-10-20 02:32:33
Message-ID: 1098239553.29787.5.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
On Wed, 2004-10-20 at 02:07, Tom Lane wrote:
> Looks reasonable to me.  Just one comment: should the
> -fno-strict-aliasing probe be inside the "if test "$GCC" = yes" part?
> It effectively was in the original.

Yeah, makes sense. Patch applied with this fix and Peter's suggested
improvement to a comment.

> > BTW, since we're on the topic of compiler options, is there a reason we
> > don't use -g3 with GCC when --enable-debug is specified? It seems worth
> > using to me.
> 
> How much does it bloat the executable?

Quite a bit, as it turns out: with CFLAGS="-O2 -g, "postgres" is 7077111
bytes. With CFLAGS="-O2 -g3", "postgres" is 51227279 bytes. So there is
quite an increase -- I guess we had better stick with -g then.

-Neil



In response to

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2004-10-20 02:52:57
Subject: Re: Possible make_oidjoins_check Security Issue
Previous:From: Reini UrbanDate: 2004-10-20 01:07:05
Subject: Re: Where is the link to cygwin?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group