| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Sean Chittenden <chitt(at)speakeasy(dot)net> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Casting INT4 to BOOL... |
| Date: | 2004-10-11 23:29:27 |
| Message-ID: | 1097468235.14940.18.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Sun, 2004-10-10 at 16:27, Sean Chittenden wrote:
> Is there any reason why the backend doesn't cast an unquoted integer to
> a boolean value?
Can you add some regression tests, please?
The patch treats any non-zero value as "true". Is that the behavior we
want, or should we only allow "1" as an integer representation of
"true"? (I'm not sure myself, I just don't think copying C here is
necessarily the best guide.)
The patch changes the system catalog; it probably ought to also bump the
catalog version number. That also means this probably isn't 8.0
material, unless we make an unrelated system catalog change in a future
beta (... and even then, I'm not sure if I'd cal it a bug fix).
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-10-11 23:34:10 | Re: Casting INT4 to BOOL... |
| Previous Message | Neil Conway | 2004-10-11 23:29:16 | Re: minor code cleanup |