Skip site navigation (1) Skip section navigation (2)

Re: MSVC build broken (again)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: MSVC build broken (again)
Date: 2006-10-03 20:36:13
Message-ID: 10793.1159907773@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> Would it be possible to move the whole <crtdefs.h> block into win32.h?

> Nope, it needs to go before <stdio.h> and friends, unfortunatly.

OK, patch committed as-is then.  The whole thing still looks awfully
icky though, particularly the way pg_config_os.h is included in one
place for WIN32 and a different place everywhere else.

Would it make sense to split win32.h into two files, one that's included
in the normal pg_config_os.h place and one included after the system
includes?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-10-03 20:40:18
Subject: Re: vcbuild bison check
Previous:From: Zdenek KotalaDate: 2006-10-03 20:31:20
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch

pgsql-patches by date

Next:From: Tom LaneDate: 2006-10-03 20:40:18
Subject: Re: vcbuild bison check
Previous:From: Zdenek KotalaDate: 2006-10-03 20:31:20
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group