| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
| Date: | 2012-02-09 15:17:59 |
| Message-ID: | 10416.1328800679@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 2012:
>> src/tools/check_keywords.pl is your friend.
> I wondered a couple of weeks ago if we could, instead, generate the
> lists in gram.y from kwlist.h.
We've looked into that in the past. bison does not seem to have any
sort of "include" directive, which means the only way to do it would be
to have the gram.y file be built from pieces at compile time. Although
Michael is successfully doing something of the sort for ecpg, I find it
way too ugly in return for the amount of benefit we'd get.
If people are sufficiently worried about this, a better answer would be
to teach the makefiles to run check_keywords.pl during every build.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2012-02-09 16:35:36 | Re: pgsql: Have pg_receivexlog always send an invalid log position in statu |
| Previous Message | Alvaro Herrera | 2012-02-09 13:45:45 | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2012-02-09 15:36:23 | Re: Progress on fast path sorting, btree index creation time |
| Previous Message | Simon Riggs | 2012-02-09 15:16:04 | Re: 16-bit page checksums for 9.2 |