Re: I want to send comments to the backend!

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Gerhard Häring <lists(at)ghaering(dot)de>, pgsql-interfaces(at)postgresql(dot)org
Subject: Re: I want to send comments to the backend!
Date: 2003-03-21 05:41:34
Message-ID: 10177.1048225294@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> OK, this patch fixes the comment passing bug. I remove the strspn() and
> added a boolean to test if any parsetree had been generated --- if not,
> I call NullCommand().

Seems like the hard way. I had in mind a quick

if (parsetree_list == NIL)
{
NullCommand(dest);
return;
}

before entering the main loop. It'd take a small amount of reordering
of the existing code to make this happen without adding any more code
than that, but it looked doable.

regards, tom lane

In response to

Responses

Browse pgsql-interfaces by date

  From Date Subject
Next Message Bruce Momjian 2003-03-21 05:55:20 Re: I want to send comments to the backend!
Previous Message Bruce Momjian 2003-03-21 05:16:52 Re: I want to send comments to the backend!