From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Robert Haas <robertmhaas(at)gmail(dot)com>
Cc:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>,
Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject:
pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date:
2009-08-11 15:56:18
Message-ID:
10143.1250006178@sss.pgh.pa.us (view raw or flat )
Thread:
2009-08-10 20:16:05 from alvherre(at)postgresql(dot)org (Alvaro Herrera)
2009-08-10 20:17:58 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-10 20:22:47 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-10 20:31:43 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-10 23:08:04 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-10 20:31:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-10 21:39:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-10 22:03:11 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-10 22:52:04 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 03:40:04 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-11 15:56:18 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 16:43:09 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-11 16:52:37 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-11 17:42:08 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-11 18:33:41 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-11 18:53:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 19:19:01 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-11 19:28:26 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-11 19:51:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 23:06:04 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-11 23:14:45 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-11 23:12:50 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-12 01:42:37 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 01:55:39 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-12 00:10:01 from Greg Stark <gsstark(at)mit(dot)edu>
2009-08-12 01:05:29 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 01:29:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 01:42:50 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-12 01:54:21 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-12 02:08:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 02:49:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 04:27:16 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 04:54:40 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-12 05:00:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 13:26:29 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-12 13:35:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 13:56:37 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 13:34:41 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 13:38:30 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-12 13:57:15 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 13:58:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-committers pgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Aug 10, 2009 at 6:52 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Only if they aren't applied by then. One reason that we normally only
>> run pgindent at the end of the devel cycle is that that's when
>> (presumably) the smallest amount of patches remain outstanding.
> OK, I get it. Thanks for bearing with me. The theory that the
> smallest amount of patches remain outstanding at that point is
> probably only true if the pgindent run is done relatively soon after
> the last CommitFest. In the 8.4 cycle, the pgindent run was done
> something like 7 months after the start of the last CommitFest, by
> which time a fair number of patches had accumulated.
Yeah, that's a fair point. Maybe we should institute a new policy that
pgindent should happen immediately after close of the last commitfest
in a cycle, instead of delaying until almost release time.
A more aggressive approach would be to run pgindent immediately after
the close of *each* commitfest, but that would tend to break patches
that had gotten punted to the next fest.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Joshua D. DrakeDate: 2009-08-11 15:58:00Subject : Re: "Hot standby"?Previous :From : Fujii MasaoDate : 2009-08-11 15:30:01Subject : Re: Hot standby and synchronous replication status
pgsql-committers by date
Next :From: Robert HaasDate: 2009-08-11 16:43:09Subject : Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)Previous :From : Bruce MomjianDate : 2009-08-11 12:02:58Subject : pgsql: Remove tab in SGML.
