Skip site navigation (1) Skip section navigation (2)

Bug in org.postgresql.Connection

From: Ned Wolpert <ned(dot)wolpert(at)knowledgenet(dot)com>
To: PostgreSQL-JDBC <pgsql-jdbc(at)postgresql(dot)org>
Subject: Bug in org.postgresql.Connection
Date: 2001-12-07 22:39:26
Message-ID: 1007764766.30152.2.camel@osti.knowledgenet.corp (view raw or flat)
Thread:
Lists: pgsql-jdbc
This was right on the tip of my sight, but I missed it in my last email
message:

Bug in the method getSQLType(int oid).  It looks for an integer in
   Integer sqlType = (Integer)typeOidCache.get(iOid);
But when none found, it does a query to the database to get the value. 
But it never puts it into the hashtable/cache.  The method does the
following:
   sqlTypeCache.put(iOid, sqlType);
   pgTypeCache.put(iOid, pgType);
One of two things should happend.  
  1) change line (1118) from 
         sqlTypeCache.put(iOid,sqlType);
     to  
         typeOidCache.put(iOid,sqlType);
  
  or

  2) add in the line
         typeOidCache.put(iOid,sqlType);
     in line 1118

My question is, that sqlTypeCache is only used here, but typeOidCache is
used in several places.  Should we remove sqlTypeCache and only use
typeOidCache or are both needed?


-- 

Virtually, 
Ned Wolpert <ned(dot)wolpert(at)knowledgenet(dot)com>

D08C2F45:  28E7 56CB 58AC C622 5A51  3C42 8B2B 2739 D08C 2F45 

Responses

pgsql-jdbc by date

Next:From: Ned WolpertDate: 2001-12-07 23:05:53
Subject: Re: Bug in org.postgresql.Connection
Previous:From: Ned WolpertDate: 2001-12-07 22:09:51
Subject: Bug with caching SQLTypes in Connection:getSQLType(oid)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group