Skip site navigation (1) Skip section navigation (2)

Re: postgresql 9.0.3: parallel restore fails with comments on indices

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Arnd Hannemann <arnd(dot)hannemann(at)credativ(dot)de>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: postgresql 9.0.3: parallel restore fails with comments on indices
Date: 2011-02-18 17:35:13
Message-ID: 10032.1298050513@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Arnd Hannemann <arnd(dot)hannemann(at)credativ(dot)de> writes:
> if pg_restore is used with -jN it fails if the dump has comments on indices.

Reproduced here, thanks for the report!

> The problem seems to be a false assumption in pg_backup_archiver.c:
> ...
> Comments are in SECTION_NONE so they get restored here regardless of dependencies, which is obviously wrong

Yeah, that seems to need a bit more thought.  It's intentional that
comments that are in the PRE_DATA area get restored immediately, so as
not to eat all the overhead of a worker subprocess for them.  But we
can't do it that way for comments intermixed with POST_DATA items.

I think the simplest fix is to allow this loop to process SECTION_NONE
items only as long as it hasn't skipped any prior items.

			regards, tom lane

In response to

pgsql-bugs by date

Next:From: Tom LaneDate: 2011-02-18 18:21:12
Subject: Re: BUG #5894: Rules' behaviour when SERIAL data types are used
Previous:From: Piergiorgio BuongiovanniDate: 2011-02-18 15:47:24
Subject: BUG #5894: Rules' behaviour when SERIAL data types are used

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group