From: | "Rod Taylor" <rbt(at)zort(dot)ca> |
---|---|
To: | "Peter Eisentraut" <peter_e(at)gmx(dot)net> |
Cc: | <pgsql-patches(at)postgresql(dot)org>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Subject: | Re: Domain Support -- another round |
Date: | 2002-03-12 03:25:27 |
Message-ID: | 0e6d01c1c975$905e99c0$b002000a@jester |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
New set with most of Peters comments corrected. Left the deal about
schema though :) Took nearly an hour to do a cvs diff for some reason
this time (normally a couple of minutes is enough).
> Random nitpicking below. Also, have you created a regression test?
They had been posted a few times and haven't changed. (Attached
anyway)
> > + <structfield>typnotnull</structfield> represents a NOT NULL
> > + constraint on a type. Normally used only for domains.
>
> And unnormally...?
Unnormally is when someone sets it by hand on a type which isn't a
domain -- I guess. Corrected.
> > + <!entity createDomain system "create_domain.sgml">
>
> I don't see this file included.
Other messages. Full package included on this one however.
> > + * MergeDomainAttributes
> > + * Returns a new table schema with the constraints, types,
and other
> > + * attributes of the domain resolved for fields using the
domain as
> > + * their type.
>
> I didn't know we had schemas yet. You should probably not overload
that
> term to mean "a list of database objects".
Merge attributes says something very similar about inheritance and
table schemas. Kinda correct considering
the variable used in both cases is *schema.
The diff weirdness in regards to DROP DATABASE is probably because I
started by copying the DROP DATABASE element, then altered it. I
don't know why it chose that method to do the diff though, but it is
accurate. Using -cd flags didn't make it any prettier.
Attachment | Content-Type | Size |
---|---|---|
domainregress.sql | application/octet-stream | 3.2 KB |
create_domain.sgml | application/octet-stream | 6.5 KB |
drop_domain.sgml | application/octet-stream | 3.7 KB |
domain.patch | application/octet-stream | 109.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Lau | 2002-03-12 03:40:33 | Get Object? |
Previous Message | Tom Lane | 2002-03-12 02:11:01 | Re: Promising results with Intel Linux x86 compiler |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-03-12 04:42:28 | Re: Domain Support -- another round |
Previous Message | Christopher Kings-Lynne | 2002-03-12 02:35:35 | Re: support for POSIX 1003.1-2001 hosts |