New set with most of Peters comments corrected. Left the deal about
schema though :) Took nearly an hour to do a cvs diff for some reason
this time (normally a couple of minutes is enough).
> Random nitpicking below. Also, have you created a regression test?
They had been posted a few times and haven't changed. (Attached
> > + <structfield>typnotnull</structfield> represents a NOT NULL
> > + constraint on a type. Normally used only for domains.
> And unnormally...?
Unnormally is when someone sets it by hand on a type which isn't a
domain -- I guess. Corrected.
> > + <!entity createDomain system "create_domain.sgml">
> I don't see this file included.
Other messages. Full package included on this one however.
> > + * MergeDomainAttributes
> > + * Returns a new table schema with the constraints, types,
> > + * attributes of the domain resolved for fields using the
> > + * their type.
> I didn't know we had schemas yet. You should probably not overload
> term to mean "a list of database objects".
Merge attributes says something very similar about inheritance and
table schemas. Kinda correct considering
the variable used in both cases is *schema.
The diff weirdness in regards to DROP DATABASE is probably because I
started by copying the DROP DATABASE element, then altered it. I
don't know why it chose that method to do the diff though, but it is
accurate. Using -cd flags didn't make it any prettier.
Description: application/octet-stream (109.0 KB)
In response to
pgsql-hackers by date
|Next:||From: Alex Lau||Date: 2002-03-12 03:40:33|
|Subject: Get Object?|
|Previous:||From: Tom Lane||Date: 2002-03-12 02:11:01|
|Subject: Re: Promising results with Intel Linux x86 compiler |
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2002-03-12 04:42:28|
|Subject: Re: Domain Support -- another round|
|Previous:||From: Christopher Kings-Lynne||Date: 2002-03-12 02:35:35|
|Subject: Re: support for POSIX 1003.1-2001 hosts|