Skip site navigation (1) Skip section navigation (2)

Re: Warning is adjusted of pgbench.

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>,<pgsql-patches(at)postgresql(dot)org>
Subject: Re: Warning is adjusted of pgbench.
Date: 2007-09-26 03:25:54
Message-ID: 0b2301c7ffec$f2282370$c601a8c0@HP22720319231 (view raw or flat)
Thread:
Lists: pgsql-patches
Hi.

From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>


> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
>> From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>>> Perhaps instead postgres_fe.h should #define FRONTEND?
> 
>> Yes,  I feared that the physique of a main part broke. Then, Magnus said the 
>> same suggestion as you. It seems that it needs to be brushup.
>> I am going to improve by the reason referred to as that FRONTEND influences 
>> nmake (libpq) again. Probably, Mugnus is operating main part.?
> 
> To be clear: my thought is to put "#define FRONTEND 1" into
> postgres_fe.h and then eliminate ad-hoc definitions of it from a
> boatload of Makefiles.  A quick grep suggests that the only place this
> wouldn't work too well is src/port/, but that could keep on doing what
> it's doing.

I think sufficient suggestion.

> 
> I'm not in a good position to test this, because it will mainly matter
> on Windows which I don't do.  Anyone else have a chance to try it?

I want, will try it. of course, work of Magnus is not barred. 
Thanks!

Regards,
Hiroshi Saito

In response to

Responses

pgsql-patches by date

Next:From: ITAGAKI TakahiroDate: 2007-09-26 04:43:34
Subject: Re: Thread-safe PREPARE in ecpg
Previous:From: Tom LaneDate: 2007-09-26 03:05:55
Subject: Re: Warning is adjusted of pgbench.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group