Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

From: NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Cc: NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>
Subject: Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date: 2011-11-27 14:18:45
Message-ID: 062D1CF0-C3E2-4ACF-8980-982A364D76AD@staff.kanazawa-u.ac.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

>>>> +/* __MINGW64_VERSION_MAJOR is related to both 32/64 bit gcc compiles by
>>>> + * mingw-w64, however it gots defined only after
>>>> Why not use __MINGW32__, which is defined without including any headers?
>>
>> Because it's defined by other than mingw-w64 compilers.
>
> I see. That's because mingw (not -w64).
> Should it be ok if mingw is ok with that condition?

This really breaks mingw gcc 4.6.1 :( it does not have crtdefs.h)
If moving downward do not break MSVC, perhaps its the good way.
Otherwise, we might check for the presence of crtdefs.h with configure?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2011-11-27 14:23:16 Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com
Previous Message Andrew Dunstan 2011-11-27 14:11:22 Re: Patch: Perl xsubpp