Skip site navigation (1) Skip section navigation (2)

[pgAdmin III] #267: Bugs in dlgType

From: "pgAdmin Trac" <trac(at)code(dot)pgadmin(dot)org>
To:
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: [pgAdmin III] #267: Bugs in dlgType
Date: 2010-10-24 01:39:03
Message-ID: 045.2b1248da8a8e3984218e042df14cf0c1@code.pgadmin.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
#267: Bugs in dlgType
---------------------+------------------------------------------------------
 Reporter:  gleu     |       Owner:  gleu
     Type:  bug      |      Status:  new 
 Priority:  minor    |   Milestone:      
Component:  pgadmin  |     Version:  1.12
 Keywords:  type     |    Platform:  all 
---------------------+------------------------------------------------------
 All the bugs are related to composite types.

 Let's say I add two members. First one is named c1, of type varchar(10),
 and second one is an integer named c2. If I click on c1, I see a datatype
 "character varying(10)" and a length of 10. Length textbox is disabled,
 whereas it should be enabled because the composite type isn't yet created
 and I should be able to change it. I also think that datatype should
 display "character varying" (ie, without the length). As the combobox is
 enabled, a user can think he could change the length by typing it, but
 alas, put another length and the "Add/change" button is suddenly disabled
 (because the "character varying(20)" is not part of the cached type. You
 can of course get rid of the length to only have "character varying",
 which is found in the types cache and which makes the Length textbox
 enabled. I would say umbersome UI, don't you think.

 But wait, there's more. Click on the integer member. The length textbox
 still shows the length of the previous member you selected (and precision
 too if you have one). Length and Precision textboxes are disabled, but it
 still is a weird UI.

 Now, let's add a third member, c3 of type numeric(10,5). Select the c1
 member. Oh, Length textbox is still enabled. Precision textbox still shows
 2. Click on the c2 member, same behaviour (I have an integer member with a
 length of 10 (remember the textbox is enabled), and a disabled precision
 of 2. Now click again on the c1 member, and change the size to 12. Click
 on the c2 member: Length enabled of value 12, and Precision disabled of
 value 2. Weirder. Click on member c3: Length enabled of value 12 (whereas
 it should be 10), Precision disabled of value 2.

 In fact, the datatype combobox always shows the good type, with length and
 precision. The issue is that you need to change the text in the combobox
 to make it look like before, and then change Length and Precision to the
 correct ones, to be able to change the type. And you have to forget the
 values in these textboxes when you select a member because they usually
 are wrong.

-- 
Ticket URL: <http://code.pgadmin.org/trac/ticket/267>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-10-24 01:40:52
Subject: pgAdmin III commit: Fix a lot of issues with length and precision
Previous:From: Guillaume LelargeDate: 2010-10-24 01:36:16
Subject: pgAdmin III commit: Force the query font on the results grid

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group