Skip site navigation (1) Skip section navigation (2)

Re: "identifiers" pga3 patch

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "efesar" <efesar(at)nmia(dot)com>, <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: "identifiers" pga3 patch
Date: 2003-03-12 20:37:30
Message-ID: 03AF4E498C591348A42FC93DEA9661B8259D9C@mail.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgadmin-hackers

> -----Original Message-----
> From: efesar [mailto:efesar(at)nmia(dot)com] 
> Sent: 12 March 2003 02:34
> To: pgadmin-hackers(at)postgresql(dot)org
> Subject: [pgadmin-hackers] "identifiers" pga3 patch
> 
> 
> Dave,
> 
> From the SQL docs (1.1.1): "SQL identifiers and key words 
> must begin with a letter (a-z, but also letters with 
> diacritical marks and non-Latin letters) or an underscore 
> (_). Subsequent characters in an identifier or key word can 
> be letters, digits (0-9), or underscores, although the SQL 
> standard will not define a key word that contains digits or 
> starts or ends with an underscore."
> 
> Do we have a function built yet that checks for this in pga3 
> yet? If not, I built one and stuck it in the globals. Here 
> are the patches for misc.h and misc.cpp.

The closest we have is a function to check whether we should quote an
identifier, so I've added this one. Not knowing what a diacritical is,
checking for one is beyond me as well :-)

Anyway, I've added your patch, and also committed it and your previous
work to CVS. It needs work obviously, but is a promising enough start to
warrant committing it in an incomplete state I think.

Thanks again for your efforts

Regards, Dave.

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2003-03-12 21:12:51
Subject: Re: import definition of column ...
Previous:From: efesarDate: 2003-03-12 02:51:52
Subject: Re: "identifiers" pga3 patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group