Skip site navigation (1) Skip section navigation (2)

psql: rollback only last query on error

From: "Michael Paesold" <mpaesold(at)gmx(dot)at>
To: <pgsql-patches(at)postgresql(dot)org>
Subject: psql: rollback only last query on error
Date: 2004-09-21 12:30:17
Message-ID: 01f901c49fd6$c0ea1300$ad01a8c0@zaphod (view raw or flat)
Thread:
Lists: pgsql-patches
I am sorry for kind of reposting this, but I have not got any response to my
patch sent for comment to hackers (Subject: Rollback on error):
http://archives.postgresql.org/pgsql-hackers/2004-09/msg00576.php

I just want to find out, if I should try to solve the issues with this patch
(and add regression tests, docs, etc.) now or leave it till after release of
version 8.0.

Reading responses on my intial post I think the feature is not unwelcome, at
least if implemented well, so that it will not do anything unexpected. I
understand this is beta now, and this is a new feature in psql.

Nevertheless I believe it is good to include the feature now, because

a) It increases the testing of savepoints since more people will use
savepoints (all who activate the mode in psql that my patch provides).

b) Given I finish the open issues, the patch has no backward compatibility
issues with scripts etc., even if you put \set IMPLICIT_SAVEPOINTS 'on' in
.psqlrc. For IMPLICIT_SAVEPOINTS 'off' there is no change at all.

c) The code change is rather local and does not add much complexity.

d) Some people trying 8.0 for the first time might find the current behavior
of psql odd if they are used to oracle, mssql etc. At least at the
interactive level, the patch would give them the option to have their
accustomed way of handling e.g. typos.

Thank you for your time and thank you for any response!

Best Regards,
Michael Paesold

P.S. attached is a version of the patch with more/better comments.

Attachment: savepoints.patch
Description: application/octet-stream (2.4 KB)

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2004-09-21 13:34:52
Subject: Re: psql: rollback only last query on error
Previous:From: Michael PaesoldDate: 2004-09-21 11:20:36
Subject: Re: psql \set case sensitive for boolean (OFF/off)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group